Fix https://github.com/felicity-iiith/contest-portal-frontend/issues/1 #4
Conversation
| <p> | ||
| {question.body} | ||
| </p> | ||
| {error && <div className="error">ERROR: {error}</div>} | ||
| <ul class="Nav"> | ||
| <li><a rel="prev" href="question/1" id="prv">< Prev</a></li> |
There was a problem hiding this comment.
What I wanted is that you use props.params.qno and find the previous and the next question number. Note that this would be a string so parseInt it at the start of the render function and use that with template strings in the url routes.
| @@ -17,3 +17,47 @@ | |||
| .error { | |||
| color: red; | |||
| } | |||
|
|
|||
There was a problem hiding this comment.
We use milligram CSS and want to keep additional styling as minimal as possible. Please use buttons. This is because we want to later easily change this styling (the lower the classes, the easier it is to change) for each year's theme
src/Navbar/index.js
Outdated
| @@ -9,7 +9,11 @@ export default () => ( | |||
| {!window.email ? | |||
| <li className="navigation-item"><Link to='/login' className="navigation-link">Login</Link></li> | |||
| : | |||
| <li className="navigation-item"><Link to='/logout' className="navigation-link">Logout</Link></li> | |||
| <li className="navigation-item"> | |||
There was a problem hiding this comment.
Each item is supposed to be a different "navigation-item" (especially when we hover over it and highlight. As react can only have one element in an conditional statement, bring the <ul clssname... from up into the condition values.
src/Navbar/index.js
Outdated
| @@ -9,7 +9,11 @@ export default () => ( | |||
| {!window.email ? | |||
| <li className="navigation-item"><Link to='/login' className="navigation-link">Login</Link></li> | |||
| : | |||
| <li className="navigation-item"><Link to='/logout' className="navigation-link">Logout</Link></li> | |||
| <li className="navigation-item"> | |||
| <Link to='/' className="navigation-link">Hello {window.email} </Link> | |||
There was a problem hiding this comment.
Indent when you are defining a child (<Link>) of an element (<li>)
There was a problem hiding this comment.
Also I would like that you make 2 commits as this is another issue. Atomic commits help going back in the project history
There was a problem hiding this comment.
Sorry my bad, you already made two. When making the commits, also give a brief description of the issue as in
Add username in navbar (Fixes #2)
Added UI for links to previous and next page as buttons. Linking of the buttons is not done